From 7d2a2cc4d5b4a0ab0c476f098c8c7f5354ccff10 Mon Sep 17 00:00:00 2001 From: Joshua Higgins Date: Tue, 3 Nov 2026 21:02:36 -0500 Subject: [PATCH] feat(mobile): include media names in share previews --- apps/mobile/README.md | 2 +- apps/mobile/app/(app)/(tabs)/home/album/[id].tsx | 3 ++- apps/mobile/app/(app)/(tabs)/home/artist/[id].tsx | 6 +++++- .../mobile/app/(app)/(tabs)/home/browse/artists.tsx | 2 +- apps/mobile/app/(app)/(tabs)/home/playlist/[id].tsx | 2 ++ apps/mobile/components/media-cards.tsx | 10 +++++++--- apps/mobile/components/player.tsx | 1 + apps/mobile/lib/media-links.ts | 3 ++- apps/mobile/lib/share-media-link.ts | 13 +++++++++---- apps/mobile/native/MediaLinkShare.kt | 5 +++-- apps/mobile/native/MediaLinkShare.swift | 9 ++++++--- 11 files changed, 39 insertions(+), 17 deletions(-) diff --git a/apps/mobile/README.md b/apps/mobile/README.md index 110a662..7fb65bd 100644 --- a/apps/mobile/README.md +++ b/apps/mobile/README.md @@ -38,7 +38,7 @@ in memory through setup and sign-in, and is opened after authentication. The browser may ask before opening the app. If the app is absent, the web page remains available. Native changes still require a new mobile build. -Native sharing supplies artwork through iOS link metadata and Android's chooser +Native sharing supplies media titles and artwork through iOS link metadata and Android's chooser thumbnail, while sharing the original HTTPS URL. Receiving apps control whether they display previews. If artwork cannot load, the URL is still shared. Existing builds without the native sharing module fall back to URL-only sharing. diff --git a/apps/mobile/app/(app)/(tabs)/home/album/[id].tsx b/apps/mobile/app/(app)/(tabs)/home/album/[id].tsx index 9c8dbf2..c1de515 100644 --- a/apps/mobile/app/(app)/(tabs)/home/album/[id].tsx +++ b/apps/mobile/app/(app)/(tabs)/home/album/[id].tsx @@ -186,7 +186,7 @@ export default function AlbumScreen() { stationArtistId={album.artist.id} selectedCount={album.tracks.length} favorited={isAlbumFav(album.id)} - share={{ type: "album", albumId: album.id }} + share={{ type: "album", albumId: album.id, title: album.title }} onAction={(action) => void handleAlbumDetailAction( album.id as Id<"albums">, @@ -406,6 +406,7 @@ const AlbumTrackRow = memo(function AlbumTrackRow({ type: "song", albumId: album.id, songId: track.id, + title: `${track.title} - ${album.title}`, }} onAction={(action) => void onAction(track, album, action)} > diff --git a/apps/mobile/app/(app)/(tabs)/home/artist/[id].tsx b/apps/mobile/app/(app)/(tabs)/home/artist/[id].tsx index bf9f835..ef90e47 100644 --- a/apps/mobile/app/(app)/(tabs)/home/artist/[id].tsx +++ b/apps/mobile/app/(app)/(tabs)/home/artist/[id].tsx @@ -75,7 +75,11 @@ export default function ArtistScreen() { void handleArtistAction(data.artist, action) } diff --git a/apps/mobile/app/(app)/(tabs)/home/browse/artists.tsx b/apps/mobile/app/(app)/(tabs)/home/browse/artists.tsx index 42999a1..260a1c8 100644 --- a/apps/mobile/app/(app)/(tabs)/home/browse/artists.tsx +++ b/apps/mobile/app/(app)/(tabs)/home/browse/artists.tsx @@ -142,7 +142,7 @@ const ArtistRow = memo(function ArtistRow({ return ( void onAction(artist, action)} > void handleAlbumAction(album, action)} > @@ -125,7 +125,7 @@ export const ArtistCard = memo(function ArtistCard({ return ( void handleArtistAction(artist, action)} > @@ -176,7 +176,11 @@ export const PlaylistCard = memo(function PlaylistCard({ return ( void handlePlaylistAction(playlist, action)} > diff --git a/apps/mobile/components/player.tsx b/apps/mobile/components/player.tsx index 25dc922..2d074ad 100644 --- a/apps/mobile/components/player.tsx +++ b/apps/mobile/components/player.tsx @@ -147,6 +147,7 @@ export const SongListRow = memo(function SongListRow({ type: "song", albumId: song.album.id, songId: song.id, + title: `${song.title} - ${song.album.title}`, }, onAction: (action) => onAction(song, action), }} diff --git a/apps/mobile/lib/media-links.ts b/apps/mobile/lib/media-links.ts index a87be1e..d04d8b3 100644 --- a/apps/mobile/lib/media-links.ts +++ b/apps/mobile/lib/media-links.ts @@ -1,8 +1,9 @@ -export type MediaShareContext = +export type MediaShareContext = ( | { type: "album"; albumId: string } | { type: "song"; albumId: string; songId: string } | { type: "playlist"; playlistId: string; isFavorites?: boolean } | { type: "artist"; artistId: string } +) & { title: string } export function shouldShowShare( share: MediaShareContext | undefined, diff --git a/apps/mobile/lib/share-media-link.ts b/apps/mobile/lib/share-media-link.ts index c62b667..076992b 100644 --- a/apps/mobile/lib/share-media-link.ts +++ b/apps/mobile/lib/share-media-link.ts @@ -7,7 +7,7 @@ import { mediaShareUrl } from "@/lib/media-links" import { showError } from "@/lib/toast" const nativeShare = requireOptionalNativeModule<{ - share: (url: string, artwork: string) => Promise + share: (url: string, artwork: string, title: string) => Promise }>("MediaLinkShare") export async function shareMediaLink( @@ -22,7 +22,7 @@ export async function shareMediaLink( showError("Sharing is not available on this device") return } - await Sharing.shareAsync(url, { dialogTitle: "Share" }) + await Sharing.shareAsync(url, { dialogTitle: share.title }) return } @@ -38,12 +38,17 @@ export async function shareMediaLink( : share.playlistId await nativeShare.share( url, - `${serverUrl.replace(/\/+$/, "")}/api/${type}/${id}/cover?size=512` + `${serverUrl.replace(/\/+$/, "")}/api/${type}/${id}/cover?size=512`, + share.title ) return } - await Share.share(Platform.OS === "ios" ? { url } : { message: url }) + await Share.share( + Platform.OS === "ios" + ? { url, title: share.title } + : { message: url, title: share.title } + ) } catch (error) { if (error instanceof Error && /cancel/i.test(error.message)) { return diff --git a/apps/mobile/native/MediaLinkShare.kt b/apps/mobile/native/MediaLinkShare.kt index a6a6c41..0937c67 100644 --- a/apps/mobile/native/MediaLinkShare.kt +++ b/apps/mobile/native/MediaLinkShare.kt @@ -11,12 +11,13 @@ import java.net.URL class MediaLinkShare : Module() { override fun definition() = ModuleDefinition { Name("MediaLinkShare") - AsyncFunction("share") { link: String, artwork: String -> + AsyncFunction("share") { link: String, artwork: String, title: String -> val context = requireNotNull(appContext.reactContext) val intent = Intent(Intent.ACTION_SEND).apply { type = "text/plain" putExtra(Intent.EXTRA_TEXT, link) - putExtra(Intent.EXTRA_TITLE, "oTunes") + putExtra(Intent.EXTRA_TITLE, title) + putExtra(Intent.EXTRA_SUBJECT, title) } // ClipData supplies the chooser thumbnail while the shared item stays a URL. try { diff --git a/apps/mobile/native/MediaLinkShare.swift b/apps/mobile/native/MediaLinkShare.swift index add7086..0a91454 100644 --- a/apps/mobile/native/MediaLinkShare.swift +++ b/apps/mobile/native/MediaLinkShare.swift @@ -5,9 +5,11 @@ internal import ExpoModulesCore private final class MediaLinkItem: NSObject, UIActivityItemSource { let url: URL let image: UIImage? - init(url: URL, image: UIImage?) { + let title: String + init(url: URL, image: UIImage?, title: String) { self.url = url self.image = image + self.title = title } func activityViewControllerPlaceholderItem(_ controller: UIActivityViewController) -> Any { url } func activityViewController(_ controller: UIActivityViewController, itemForActivityType: UIActivity.ActivityType?) -> Any? { url } @@ -15,6 +17,7 @@ private final class MediaLinkItem: NSObject, UIActivityItemSource { let metadata = LPLinkMetadata() metadata.originalURL = url metadata.url = url + metadata.title = title if let image { metadata.imageProvider = NSItemProvider(object: image) metadata.iconProvider = NSItemProvider(object: image) @@ -26,7 +29,7 @@ private final class MediaLinkItem: NSObject, UIActivityItemSource { final class MediaLinkShare: Module { public func definition() -> ExpoModulesCore.ModuleDefinition { Name("MediaLinkShare") - AsyncFunction("share") { (link: String, artwork: String) in + AsyncFunction("share") { (link: String, artwork: String, title: String) in guard let url = URL(string: link), let artworkURL = URL(string: artwork) else { return } var image: UIImage? var request = URLRequest(url: artworkURL) @@ -39,7 +42,7 @@ final class MediaLinkShare: Module { await MainActor.run { guard let presenter = self.appContext?.utilities?.currentViewController() else { return } let controller = UIActivityViewController( - activityItems: [MediaLinkItem(url: url, image: artworkImage)], applicationActivities: nil) + activityItems: [MediaLinkItem(url: url, image: artworkImage, title: title)], applicationActivities: nil) if let popover = controller.popoverPresentationController { popover.sourceView = presenter.view popover.sourceRect = CGRect(x: presenter.view.bounds.midX, y: presenter.view.bounds.midY, width: 0, height: 0)