Revert "feat(mobile): scroll-away inline screen titles on iOS (#129)"

This reverts commit 249def86a0.
This commit is contained in:
joshuafhiggins committed 2026-11-20 00:53:13 -05:00 Verified
1 parent 750920010b
commit 92ba14f4ff
21 files changed
+78 -343

No files matched your search

@@ -1,11 +1,7 @@
import { Stack } from "expo-router" import { Stack } from "expo-router"
import { renderTabScreenContent } from "@/components/tab-screen-content" import { renderTabScreenContent } from "@/components/tab-screen-content"
import { import { useStackScreenOptions, tabStackScreenTitles } from "@/lib/navigation"
inlineTitleOptions,
tabStackScreenTitles,
useStackScreenOptions,
} from "@/lib/navigation"
import { tabletSections, TabletSectionContext } from "@/lib/tablet-navigation" import { tabletSections, TabletSectionContext } from "@/lib/tablet-navigation"
export default function TabletSectionLayout({ segment }: { segment: string }) { export default function TabletSectionLayout({ segment }: { segment: string }) {
@@ -18,7 +14,6 @@ export default function TabletSectionLayout({ segment }: { segment: string }) {
screenLayout={renderTabScreenContent} screenLayout={renderTabScreenContent}
screenOptions={({ route }) => ({ screenOptions={({ route }) => ({
...options, ...options,
...inlineTitleOptions,
title: title:
route.name === "index" route.name === "index"
? section?.title ? section?.title
@@ -2,11 +2,7 @@ import { renderTabScreenContent } from "@/components/tab-screen-content"
import { Stack } from "expo-router" import { Stack } from "expo-router"
import { ProfileHeaderButton } from "@/components/profile-header-button" import { ProfileHeaderButton } from "@/components/profile-header-button"
import { import { tabStackScreenTitles, useStackScreenOptions } from "@/lib/navigation"
inlineTitleOptions,
tabStackScreenTitles,
useStackScreenOptions,
} from "@/lib/navigation"
export const unstable_settings = { export const unstable_settings = {
anchor: "index", anchor: "index",
@@ -20,7 +16,6 @@ export default function HomeLayout() {
screenLayout={renderTabScreenContent} screenLayout={renderTabScreenContent}
screenOptions={({ route }) => ({ screenOptions={({ route }) => ({
...baseOptions, ...baseOptions,
...inlineTitleOptions,
title: tabStackScreenTitles[route.name] ?? "Home", title: tabStackScreenTitles[route.name] ?? "Home",
headerRight: headerRight:
route.name === "index" ? () => <ProfileHeaderButton /> : undefined, route.name === "index" ? () => <ProfileHeaderButton /> : undefined,
@@ -53,7 +53,7 @@ export default function AlbumsScreen() {
return ( return (
<> <>
{searchBar} {searchBar}
<MediaGridSkeleton title="Albums" /> <MediaGridSkeleton />
</> </>
) )
} }
@@ -63,7 +63,6 @@ export default function AlbumsScreen() {
{searchBar} {searchBar}
<MediaGridList <MediaGridList
title="Albums"
content={albums} content={albums}
paddingBottom={contentBottomInset} paddingBottom={contentBottomInset}
onEndReached={() => { onEndReached={() => {
@@ -2,13 +2,12 @@ import { Ionicons } from "@expo/vector-icons"
import { Stack } from "expo-router" import { Stack } from "expo-router"
import { memo, useCallback } from "react" import { memo, useCallback } from "react"
import { import {
type FlatList, FlatList,
Pressable, Pressable,
StyleSheet, StyleSheet,
Text, Text,
type ListRenderItemInfo, type ListRenderItemInfo,
} from "react-native" } from "react-native"
import Animated from "react-native-reanimated"
import { import {
MediaContextMenu, MediaContextMenu,
@@ -16,7 +15,6 @@ import {
} from "@/components/media-context-menu" } from "@/components/media-context-menu"
import { CoverImage } from "@/components/cover-image" import { CoverImage } from "@/components/cover-image"
import { ArtistListSkeleton } from "@/components/skeletons" import { ArtistListSkeleton } from "@/components/skeletons"
import { ScreenTitle, useScreenTitleScroll } from "@/components/screen-title"
import { contentBottomInset } from "@/components/player" import { contentBottomInset } from "@/components/player"
import { useServerConfig } from "@/contexts/server-config" import { useServerConfig } from "@/contexts/server-config"
import { import {
@@ -35,7 +33,6 @@ import { spacing, useThemeColors } from "@/lib/theme"
const PAGE_SIZE = 50 const PAGE_SIZE = 50
export default function ArtistsScreen() { export default function ArtistsScreen() {
const { ref, scrollY } = useScreenTitleScroll<FlatList<BrowseArtist>>()
const { push } = useAppNavigation() const { push } = useAppNavigation()
const colors = useThemeColors() const colors = useThemeColors()
const { config } = useServerConfig() const { config } = useServerConfig()
@@ -97,7 +94,7 @@ export default function ArtistsScreen() {
return ( return (
<> <>
{searchBar} {searchBar}
<ArtistListSkeleton title="Artists" /> <ArtistListSkeleton />
</> </>
) )
} }
@@ -106,11 +103,8 @@ export default function ArtistsScreen() {
<> <>
{searchBar} {searchBar}
<Animated.FlatList <FlatList
{...longListProps} {...longListProps}
ref={ref}
scrollEventThrottle={16}
ListHeaderComponent={<ScreenTitle title="Artists" scrollY={scrollY} />}
data={artists} data={artists}
keyExtractor={artistKey} keyExtractor={artistKey}
renderItem={renderItem} renderItem={renderItem}
@@ -1,4 +1,3 @@
import { useContext } from "react"
import { Pressable } from "react-native" import { Pressable } from "react-native"
import { MediaGridList } from "@/components/media-cards" import { MediaGridList } from "@/components/media-cards"
@@ -11,20 +10,19 @@ import { Ionicons } from "@expo/vector-icons"
import { Stack } from "expo-router" import { Stack } from "expo-router"
import { SymbolView } from "expo-symbols" import { SymbolView } from "expo-symbols"
import { useAddToPlaylist } from "@/contexts/add-to-playlist" import { useAddToPlaylist } from "@/contexts/add-to-playlist"
import { TabletSectionContext } from "@/lib/tablet-navigation"
export default function PlaylistsTabScreen() { export default function PlaylistsTabScreen() {
const colors = useThemeColors() const colors = useThemeColors()
const playlists = useCachedQuery(api.playlists.listAllPlaylists) const playlists = useCachedQuery(api.playlists.listAllPlaylists)
const { openCreatePlaylist } = useAddToPlaylist() const { openCreatePlaylist } = useAddToPlaylist()
const title = useContext(TabletSectionContext)?.title ?? "Playlists"
if (playlists === undefined) { if (playlists === undefined) {
return ( return (
<> <>
<Stack.Screen <Stack.Screen
options={{ options={{
title, title: "Playlists",
headerLargeTitle: true,
headerRight: () => ( headerRight: () => (
<Pressable <Pressable
onPress={openCreatePlaylist} onPress={openCreatePlaylist}
@@ -40,7 +38,7 @@ export default function PlaylistsTabScreen() {
), ),
}} }}
/> />
<MediaGridSkeleton title={title} /> <MediaGridSkeleton />
</> </>
) )
} }
@@ -49,7 +47,8 @@ export default function PlaylistsTabScreen() {
<> <>
<Stack.Screen <Stack.Screen
options={{ options={{
title, title: "Playlists",
headerLargeTitle: true,
headerRight: () => ( headerRight: () => (
<Pressable <Pressable
onPress={openCreatePlaylist} onPress={openCreatePlaylist}
@@ -62,7 +61,6 @@ export default function PlaylistsTabScreen() {
}} }}
/> />
<MediaGridList <MediaGridList
title={title}
content={playlists} content={playlists}
paddingBottom={tabContentBottomInset} paddingBottom={tabContentBottomInset}
/> />
@@ -1,16 +1,10 @@
import { Stack } from "expo-router" import { Stack } from "expo-router"
import { useCallback, useState } from "react" import { useCallback, useState } from "react"
import { import { FlatList, StyleSheet, type ListRenderItemInfo } from "react-native"
type FlatList,
StyleSheet,
type ListRenderItemInfo,
} from "react-native"
import Animated from "react-native-reanimated"
import type { MediaAction } from "@/components/media-context-menu" import type { MediaAction } from "@/components/media-context-menu"
import { contentBottomInset, SongListRow } from "@/components/player" import { contentBottomInset, SongListRow } from "@/components/player"
import { SongListSkeleton } from "@/components/skeletons" import { SongListSkeleton } from "@/components/skeletons"
import { ScreenTitle, useScreenTitleScroll } from "@/components/screen-title"
import { useFavorites } from "@/contexts/favorites" import { useFavorites } from "@/contexts/favorites"
import { usePlaybackActions } from "@/contexts/playback" import { usePlaybackActions } from "@/contexts/playback"
import { import {
@@ -26,7 +20,6 @@ import { longListProps } from "@/lib/list"
const PAGE_SIZE = 50 const PAGE_SIZE = 50
export default function SongsScreen() { export default function SongsScreen() {
const { ref, scrollY } = useScreenTitleScroll<FlatList<BrowseSong>>()
const { playFromLibrarySong } = usePlaybackActions() const { playFromLibrarySong } = usePlaybackActions()
const { isSongFavorite } = useFavorites() const { isSongFavorite } = useFavorites()
const { handleSongAction } = useMediaMenuActions() const { handleSongAction } = useMediaMenuActions()
@@ -94,7 +87,7 @@ export default function SongsScreen() {
return ( return (
<> <>
{searchBar} {searchBar}
<SongListSkeleton title="Songs" /> <SongListSkeleton />
</> </>
) )
} }
@@ -103,11 +96,8 @@ export default function SongsScreen() {
<> <>
{searchBar} {searchBar}
<Animated.FlatList <FlatList
{...longListProps} {...longListProps}
ref={ref}
scrollEventThrottle={16}
ListHeaderComponent={<ScreenTitle title="Songs" scrollY={scrollY} />}
data={songs} data={songs}
keyExtractor={songKey} keyExtractor={songKey}
renderItem={renderItem} renderItem={renderItem}
@@ -1,6 +1,6 @@
import { useMemo } from "react" import { useMemo } from "react"
import { import {
type FlatList, FlatList,
Pressable, Pressable,
StyleSheet, StyleSheet,
Text, Text,
@@ -8,10 +8,8 @@ import {
type ListRenderItemInfo, type ListRenderItemInfo,
} from "react-native" } from "react-native"
import { Stack } from "expo-router" import { Stack } from "expo-router"
import Animated from "react-native-reanimated"
import { CoverImage } from "@/components/cover-image" import { CoverImage } from "@/components/cover-image"
import { ScreenTitle, useScreenTitleScroll } from "@/components/screen-title"
import { tabContentBottomInset } from "@/components/player" import { tabContentBottomInset } from "@/components/player"
import { import {
FAVORITES_DOWNLOAD_ID, FAVORITES_DOWNLOAD_ID,
@@ -55,7 +53,6 @@ export default function DownloadsScreen() {
const { push } = useAppNavigation() const { push } = useAppNavigation()
const { columns, cardWidth, onLayout, horizontalPadding, gap } = const { columns, cardWidth, onLayout, horizontalPadding, gap } =
useMediaGridLayout() useMediaGridLayout()
const { ref, scrollY } = useScreenTitleScroll<FlatList<Card>>()
const cards = useMemo<Card[]>(() => { const cards = useMemo<Card[]>(() => {
if (!queue) return [] if (!queue) return []
@@ -138,10 +135,8 @@ export default function DownloadsScreen() {
return ( return (
<> <>
<Stack.Screen options={{ title: "Downloads" }} /> <Stack.Screen options={{ title: "Downloads", headerLargeTitle: true }} />
<Animated.FlatList <FlatList
ref={ref}
scrollEventThrottle={16}
key={columns} key={columns}
onLayout={onLayout} onLayout={onLayout}
data={cards} data={cards}
@@ -154,20 +149,13 @@ export default function DownloadsScreen() {
numColumns={columns} numColumns={columns}
style={{ flex: 1, backgroundColor: colors.background }} style={{ flex: 1, backgroundColor: colors.background }}
contentContainerStyle={{ contentContainerStyle={{
paddingTop: spacing.lg,
paddingHorizontal: horizontalPadding, paddingHorizontal: horizontalPadding,
paddingBottom: tabContentBottomInset, paddingBottom: tabContentBottomInset,
gap, gap,
}} }}
columnWrapperStyle={columns > 1 ? { gap } : undefined} columnWrapperStyle={columns > 1 ? { gap } : undefined}
contentInsetAdjustmentBehavior="automatic" contentInsetAdjustmentBehavior="automatic"
ListHeaderComponent={
<ScreenTitle
title="Downloads"
scrollY={scrollY}
// The list padding already insets the title.
style={{ paddingHorizontal: 0 }}
/>
}
ListEmptyComponent={ ListEmptyComponent={
<View style={styles.empty}> <View style={styles.empty}>
<Text style={{ color: colors.mutedForeground }}> <Text style={{ color: colors.mutedForeground }}>
@@ -1,17 +1,15 @@
import { useCallback, useMemo } from "react" import { useCallback, useMemo } from "react"
import { import {
type FlatList, FlatList,
Pressable, Pressable,
StyleSheet, StyleSheet,
Text, Text,
View, View,
type ListRenderItemInfo, type ListRenderItemInfo,
} from "react-native" } from "react-native"
import Animated from "react-native-reanimated"
import { Ionicons } from "@expo/vector-icons" import { Ionicons } from "@expo/vector-icons"
import { Stack } from "expo-router" import { Stack } from "expo-router"
import { ScreenTitle, useScreenTitleScroll } from "@/components/screen-title"
import { useSwipeRowGroup } from "@/components/ios-swipe-to-remove-row" import { useSwipeRowGroup } from "@/components/ios-swipe-to-remove-row"
import type { MediaAction } from "@/components/media-context-menu" import type { MediaAction } from "@/components/media-context-menu"
import { contentBottomInset, SongListRow } from "@/components/player" import { contentBottomInset, SongListRow } from "@/components/player"
@@ -54,7 +52,6 @@ export default function OtherDownloadsScreen() {
const { isSongFavorite } = useFavorites() const { isSongFavorite } = useFavorites()
const { handleSongAction } = useMediaMenuActions() const { handleSongAction } = useMediaMenuActions()
const swipeGroup = useSwipeRowGroup() const swipeGroup = useSwipeRowGroup()
const { ref, scrollY } = useScreenTitleScroll<FlatList<BrowseSong>>()
const handlePlaySong = useCallback( const handlePlaySong = useCallback(
(song: BrowseSong) => void playFromSong(song.id, playableIds, PLAY_ORIGIN), (song: BrowseSong) => void playFromSong(song.id, playableIds, PLAY_ORIGIN),
@@ -93,11 +90,11 @@ export default function OtherDownloadsScreen() {
return ( return (
<> <>
<Stack.Screen options={{ title: OTHER_DOWNLOADS_TITLE }} /> <Stack.Screen
<Animated.FlatList options={{ title: OTHER_DOWNLOADS_TITLE, headerLargeTitle: false }}
/>
<FlatList
{...longListProps} {...longListProps}
ref={ref}
scrollEventThrottle={16}
data={songs} data={songs}
keyExtractor={(song) => song.id} keyExtractor={(song) => song.id}
renderItem={renderItem} renderItem={renderItem}
@@ -106,32 +103,25 @@ export default function OtherDownloadsScreen() {
contentInsetAdjustmentBehavior="automatic" contentInsetAdjustmentBehavior="automatic"
onScrollBeginDrag={swipeGroup.closeOpenRow} onScrollBeginDrag={swipeGroup.closeOpenRow}
ListHeaderComponent={ ListHeaderComponent={
<> songs.length > 0 ? (
<ScreenTitle title={OTHER_DOWNLOADS_TITLE} scrollY={scrollY} /> <View style={styles.actions}>
{songs.length > 0 ? ( <Button
<View style={styles.actions}> title="Play"
<Button icon="play"
title="Play" onPress={() => void playInOrder(playableIds, PLAY_ORIGIN)}
icon="play" style={styles.play}
onPress={() => void playInOrder(playableIds, PLAY_ORIGIN)} />
style={styles.play} <Pressable
/> accessibilityRole="button"
<Pressable accessibilityLabel="Shuffle"
accessibilityRole="button" hitSlop={8}
accessibilityLabel="Shuffle" onPress={() => void playShuffled(playableIds, PLAY_ORIGIN)}
hitSlop={8} style={[styles.shuffle, { backgroundColor: colors.card }]}
onPress={() => void playShuffled(playableIds, PLAY_ORIGIN)} >
style={[styles.shuffle, { backgroundColor: colors.card }]} <Ionicons name="shuffle" size={24} color={colors.foreground} />
> </Pressable>
<Ionicons </View>
name="shuffle" ) : undefined
size={24}
color={colors.foreground}
/>
</Pressable>
</View>
) : null}
</>
} }
ListEmptyComponent={ ListEmptyComponent={
<Text style={[styles.empty, { color: colors.mutedForeground }]}> <Text style={[styles.empty, { color: colors.mutedForeground }]}>
+4 -16
View File
@@ -1,10 +1,8 @@
import { memo } from "react" import { memo } from "react"
import { type ScrollViewInstance, StyleSheet } from "react-native" import { ScrollView, StyleSheet } from "react-native"
import Animated from "react-native-reanimated"
import { ContentCarousel } from "@/components/media-cards" import { ContentCarousel } from "@/components/media-cards"
import { HomeSkeleton } from "@/components/skeletons" import { HomeSkeleton } from "@/components/skeletons"
import { ScreenTitle, useScreenTitleScroll } from "@/components/screen-title"
import { tabContentBottomInset } from "@/components/player" import { tabContentBottomInset } from "@/components/player"
import { useCachedPaginatedQuery } from "@/hooks/use-cached-query" import { useCachedPaginatedQuery } from "@/hooks/use-cached-query"
import { api } from "@otunes/convex/_generated/api" import { api } from "@otunes/convex/_generated/api"
@@ -40,7 +38,6 @@ const HomeCarousels = memo(function HomeCarousels({
export default function HomeScreen() { export default function HomeScreen() {
const colors = useThemeColors() const colors = useThemeColors()
const { ref, scrollY } = useScreenTitleScroll<ScrollViewInstance>()
const recentlyAdded = useCachedPaginatedQuery( const recentlyAdded = useCachedPaginatedQuery(
api.library.browseRecentlyAddedPaginated, api.library.browseRecentlyAddedPaginated,
{}, {},
@@ -56,16 +53,14 @@ export default function HomeScreen() {
(result) => result.status === "LoadingFirstPage" && !result.isCached (result) => result.status === "LoadingFirstPage" && !result.isCached
) )
if (isLoading) { if (isLoading) {
return <HomeSkeleton title="Home" /> return <HomeSkeleton />
} }
const added = recentlyAdded.results.slice(0, CAROUSEL_ITEM_LIMIT) const added = recentlyAdded.results.slice(0, CAROUSEL_ITEM_LIMIT)
const played = recentlyPlayed.results.slice(0, CAROUSEL_ITEM_LIMIT) const played = recentlyPlayed.results.slice(0, CAROUSEL_ITEM_LIMIT)
return ( return (
<Animated.ScrollView <ScrollView
ref={ref}
scrollEventThrottle={16}
style={{ flex: 1, backgroundColor: colors.background }} style={{ flex: 1, backgroundColor: colors.background }}
contentContainerStyle={[ contentContainerStyle={[
styles.content, styles.content,
@@ -73,9 +68,8 @@ export default function HomeScreen() {
]} ]}
contentInsetAdjustmentBehavior="automatic" contentInsetAdjustmentBehavior="automatic"
> >
<ScreenTitle title="Home" scrollY={scrollY} style={styles.title} />
<HomeCarousels recentlyAdded={added} recentlyPlayed={played} /> <HomeCarousels recentlyAdded={added} recentlyPlayed={played} />
</Animated.ScrollView> </ScrollView>
) )
} }
@@ -84,10 +78,4 @@ const styles = StyleSheet.create({
padding: spacing.lg, padding: spacing.lg,
gap: spacing.xl, gap: spacing.xl,
}, },
// The content padding already insets the title.
title: {
paddingHorizontal: 0,
marginTop: -spacing.lg,
marginBottom: -spacing.md,
},
}) })
@@ -14,12 +14,11 @@ export default function RecentlyAddedScreen() {
) )
if (status === "LoadingFirstPage" && !isCached) { if (status === "LoadingFirstPage" && !isCached) {
return <MediaGridSkeleton title="Recently Added" /> return <MediaGridSkeleton />
} }
return ( return (
<MediaGridList <MediaGridList
title="Recently Added"
content={results} content={results}
paddingBottom={contentBottomInset} paddingBottom={contentBottomInset}
onEndReached={() => { onEndReached={() => {
@@ -14,12 +14,11 @@ export default function RecentlyPlayedScreen() {
) )
if (status === "LoadingFirstPage" && !isCached) { if (status === "LoadingFirstPage" && !isCached) {
return <MediaGridSkeleton title="Recently Played" /> return <MediaGridSkeleton />
} }
return ( return (
<MediaGridList <MediaGridList
title="Recently Played"
content={results} content={results}
paddingBottom={contentBottomInset} paddingBottom={contentBottomInset}
onEndReached={() => { onEndReached={() => {
@@ -3,11 +3,7 @@ import { renderTabScreenContent } from "@/components/tab-screen-content"
import { Stack } from "expo-router" import { Stack } from "expo-router"
import { ProfileHeaderButton } from "@/components/profile-header-button" import { ProfileHeaderButton } from "@/components/profile-header-button"
import { import { tabStackScreenTitles, useStackScreenOptions } from "@/lib/navigation"
inlineTitleOptions,
tabStackScreenTitles,
useStackScreenOptions,
} from "@/lib/navigation"
export const unstable_settings = { export const unstable_settings = {
anchor: "index", anchor: "index",
@@ -22,7 +18,6 @@ export default function LibraryLayout() {
screenLayout={renderTabScreenContent} screenLayout={renderTabScreenContent}
screenOptions={({ route }) => ({ screenOptions={({ route }) => ({
...baseOptions, ...baseOptions,
...inlineTitleOptions,
title: title:
tabStackScreenTitles[route.name] ?? tabStackScreenTitles[route.name] ??
(tabletLayout ? "Recently Added" : "Library"), (tabletLayout ? "Recently Added" : "Library"),
@@ -72,7 +72,6 @@ export default function LibraryScreen() {
const { push } = useAppNavigation() const { push } = useAppNavigation()
const isTablet = tabletLayout const isTablet = tabletLayout
const colors = useThemeColors() const colors = useThemeColors()
const title = isTablet ? "Recently Added" : "Library"
const { results, status, loadMore, isCached } = useCachedPaginatedQuery( const { results, status, loadMore, isCached } = useCachedPaginatedQuery(
api.library.browseRecentlyAddedPaginated, api.library.browseRecentlyAddedPaginated,
{}, {},
@@ -125,18 +124,11 @@ export default function LibraryScreen() {
) )
if (status === "LoadingFirstPage" && !isCached) { if (status === "LoadingFirstPage" && !isCached) {
return ( return <MediaGridSkeleton contentInset={false} header={listHeader} />
<MediaGridSkeleton
title={title}
contentInset={false}
header={listHeader}
/>
)
} }
return ( return (
<MediaGridList <MediaGridList
title={title}
content={results} content={results}
paddingBottom={tabContentBottomInset} paddingBottom={tabContentBottomInset}
contentInset={false} contentInset={false}
@@ -2,11 +2,7 @@ import { renderTabScreenContent } from "@/components/tab-screen-content"
import { Stack } from "expo-router" import { Stack } from "expo-router"
import { ProfileHeaderButton } from "@/components/profile-header-button" import { ProfileHeaderButton } from "@/components/profile-header-button"
import { import { tabStackScreenTitles, useStackScreenOptions } from "@/lib/navigation"
inlineTitleOptions,
tabStackScreenTitles,
useStackScreenOptions,
} from "@/lib/navigation"
export const unstable_settings = { export const unstable_settings = {
anchor: "index", anchor: "index",
@@ -20,7 +16,6 @@ export default function SearchLayout() {
screenLayout={renderTabScreenContent} screenLayout={renderTabScreenContent}
screenOptions={({ route }) => ({ screenOptions={({ route }) => ({
...baseOptions, ...baseOptions,
...inlineTitleOptions,
title: tabStackScreenTitles[route.name] ?? "Search", title: tabStackScreenTitles[route.name] ?? "Search",
headerRight: headerRight:
route.name === "index" ? () => <ProfileHeaderButton /> : undefined, route.name === "index" ? () => <ProfileHeaderButton /> : undefined,
@@ -35,7 +35,7 @@ export default function SearchScreen() {
: {})} : {})}
/> />
<SearchResults searchQuery={searchQuery} title="Search" /> <SearchResults searchQuery={searchQuery} />
</> </>
) )
} }
+2 -25
View File
@@ -4,7 +4,6 @@ import { tabletLayoutTransition } from "@/lib/tablet-motion"
import { TabletMediaGrid } from "@/components/tablet-media-grid" import { TabletMediaGrid } from "@/components/tablet-media-grid"
import { useMediaGridLayout } from "@/hooks/use-media-grid-layout" import { useMediaGridLayout } from "@/hooks/use-media-grid-layout"
import { MusicEntityView } from "@/components/music-entity-view" import { MusicEntityView } from "@/components/music-entity-view"
import { ScreenTitle, useScreenTitleScroll } from "@/components/screen-title"
import { Link } from "expo-router" import { Link } from "expo-router"
import { Ionicons } from "@expo/vector-icons" import { Ionicons } from "@expo/vector-icons"
import { memo, useCallback, type ReactElement } from "react" import { memo, useCallback, type ReactElement } from "react"
@@ -301,21 +300,17 @@ export function MediaGridList({
onEndReached, onEndReached,
ListHeaderComponent, ListHeaderComponent,
contentInset = true, contentInset = true,
title,
}: { }: {
content: MediaItem[] content: MediaItem[]
paddingBottom: number paddingBottom: number
onEndReached?: () => void onEndReached?: () => void
ListHeaderComponent?: ReactElement ListHeaderComponent?: ReactElement
contentInset?: boolean contentInset?: boolean
/** iOS `ScreenTitle` shown above the grid; it replaces the top inset. */
title?: string
}) { }) {
const tabletLayout = useTabletLayout() const tabletLayout = useTabletLayout()
const { columns, cardWidth, onLayout, horizontalPadding, gap } = const { columns, cardWidth, onLayout, horizontalPadding, gap } =
useMediaGridLayout() useMediaGridLayout()
const colors = useThemeColors() const colors = useThemeColors()
const { ref, scrollY } = useScreenTitleScroll<FlatList<MediaItem>>()
const renderItem = useCallback( const renderItem = useCallback(
({ item }: ListRenderItemInfo<MediaItem>) => ( ({ item }: ListRenderItemInfo<MediaItem>) => (
<View style={{ width: cardWidth }}> <View style={{ width: cardWidth }}>
@@ -333,30 +328,13 @@ export function MediaGridList({
onEndReached={onEndReached} onEndReached={onEndReached}
ListHeaderComponent={ListHeaderComponent} ListHeaderComponent={ListHeaderComponent}
contentInset={contentInset} contentInset={contentInset}
title={title}
renderCard={renderTabletCard} renderCard={renderTabletCard}
/> />
) )
} }
const header = title ? (
<View>
<ScreenTitle
title={title}
scrollY={scrollY}
// Inset grids already pad the whole list horizontally.
style={{ paddingHorizontal: contentInset ? 0 : horizontalPadding }}
/>
{ListHeaderComponent}
</View>
) : (
ListHeaderComponent
)
return ( return (
<Animated.FlatList <FlatList
ref={ref}
scrollEventThrottle={16}
key={columns} key={columns}
onLayout={onLayout} onLayout={onLayout}
data={content} data={content}
@@ -373,7 +351,6 @@ export function MediaGridList({
paddingBottom, paddingBottom,
gap, gap,
...(contentInset ? { paddingHorizontal: horizontalPadding } : {}), ...(contentInset ? { paddingHorizontal: horizontalPadding } : {}),
...(title ? { paddingTop: 0 } : {}),
}, },
]} ]}
columnWrapperStyle={[ columnWrapperStyle={[
@@ -382,7 +359,7 @@ export function MediaGridList({
{ gap }, { gap },
]} ]}
contentInsetAdjustmentBehavior="automatic" contentInsetAdjustmentBehavior="automatic"
ListHeaderComponent={header} ListHeaderComponent={ListHeaderComponent}
onEndReached={onEndReached} onEndReached={onEndReached}
onEndReachedThreshold={0.5} onEndReachedThreshold={0.5}
/> />
-84
View File
@@ -1,84 +0,0 @@
import { useHeaderHeight } from "expo-router/react-navigation"
import type { Component } from "react"
import {
Platform,
StyleSheet,
type ScrollViewInstance,
type StyleProp,
type TextStyle,
} from "react-native"
import Animated, {
useAnimatedRef,
useAnimatedStyle,
useScrollOffset,
type SharedValue,
} from "react-native-reanimated"
import { spacing, useThemeColors } from "@/lib/theme"
/**
* Tracks the scroll view that renders a `ScreenTitle`. Attach `ref` to that
* Reanimated `Animated.ScrollView` / `Animated.FlatList` and pass `scrollY`
* to the title.
*/
export function useScreenTitleScroll<
TScrollView extends Component | ScrollViewInstance,
>() {
const ref = useAnimatedRef<TScrollView>()
const scrollY = useScrollOffset(ref)
return { ref, scrollY }
}
/**
* iOS screen title rendered as the first item of a screen's scroll content,
* in place of the native large title (Apple Music style): it scrolls away
* with the content, never collapses into the bar, and stays put on
* pull-down. Android keeps its native header title, so this renders nothing.
*/
export function ScreenTitle({
title,
scrollY,
style,
}: {
title: string
/** From `useScreenTitleScroll`; omit for screens that never scroll. */
scrollY?: SharedValue<number>
style?: StyleProp<TextStyle>
}) {
const colors = useThemeColors()
// At rest the scroll offset is minus the automatic header inset, so any
// offset below that is overscroll the title should cancel out.
const headerHeight = useHeaderHeight()
const pinStyle = useAnimatedStyle(() => ({
transform: [
{
translateY: scrollY ? Math.min(0, scrollY.value + headerHeight) : 0,
},
],
}))
if (Platform.OS !== "ios") return null
return (
<Animated.Text
accessibilityRole="header"
numberOfLines={2}
style={[styles.title, { color: colors.foreground }, style, pinStyle]}
>
{title}
</Animated.Text>
)
}
// Matches UIKit's large title metrics: 34pt bold in a 52pt tall area.
const styles = StyleSheet.create({
title: {
fontSize: 34,
lineHeight: 41,
fontWeight: "700",
letterSpacing: 0.37,
paddingHorizontal: spacing.lg,
paddingTop: 3,
paddingBottom: 8,
},
})
+13 -22
View File
@@ -1,15 +1,13 @@
import { memo, useCallback, useMemo } from "react" import { memo, useCallback, useMemo } from "react"
import { import {
type FlatList, FlatList,
StyleSheet, StyleSheet,
Text, Text,
View, View,
type ListRenderItemInfo, type ListRenderItemInfo,
} from "react-native" } from "react-native"
import Animated from "react-native-reanimated"
import { ContentCarousel } from "@/components/media-cards" import { ContentCarousel } from "@/components/media-cards"
import { ScreenTitle, useScreenTitleScroll } from "@/components/screen-title"
import type { MediaAction } from "@/components/media-context-menu" import type { MediaAction } from "@/components/media-context-menu"
import { tabContentBottomInset, SongListRow } from "@/components/player" import { tabContentBottomInset, SongListRow } from "@/components/player"
import { SongListSkeleton } from "@/components/skeletons" import { SongListSkeleton } from "@/components/skeletons"
@@ -21,16 +19,8 @@ import { api } from "@otunes/convex/_generated/api"
import type { BrowseSong, SearchSong } from "@otunes/convex/types" import type { BrowseSong, SearchSong } from "@otunes/convex/types"
import { spacing, useThemeColors } from "@/lib/theme" import { spacing, useThemeColors } from "@/lib/theme"
function SearchResultsBody({ function SearchResultsBody({ searchQuery }: { searchQuery: string }) {
searchQuery,
title,
}: {
searchQuery: string
/** iOS `ScreenTitle`, shown above the results and while idle. */
title: string
}) {
const colors = useThemeColors() const colors = useThemeColors()
const { ref, scrollY } = useScreenTitleScroll<FlatList<BrowseSong>>()
const { playFromSong } = usePlaybackActions() const { playFromSong } = usePlaybackActions()
const { isSongFavorite } = useFavorites() const { isSongFavorite } = useFavorites()
const { handleSongAction } = useMediaMenuActions() const { handleSongAction } = useMediaMenuActions()
@@ -86,14 +76,16 @@ function SearchResultsBody({
) )
if (isSearching) { if (isSearching) {
return <SongListSkeleton title={title} /> return <SongListSkeleton />
}
if (!hasQuery) {
return <></>
} }
return ( return (
<Animated.FlatList <FlatList
ref={ref} data={results?.songs ?? []}
scrollEventThrottle={16}
data={hasQuery ? (results?.songs ?? []) : []}
keyExtractor={(song) => song.id} keyExtractor={(song) => song.id}
style={{ flex: 1, backgroundColor: colors.background }} style={{ flex: 1, backgroundColor: colors.background }}
contentContainerStyle={{ paddingBottom: tabContentBottomInset }} contentContainerStyle={{ paddingBottom: tabContentBottomInset }}
@@ -101,8 +93,7 @@ function SearchResultsBody({
keyboardShouldPersistTaps="handled" keyboardShouldPersistTaps="handled"
ListHeaderComponent={ ListHeaderComponent={
<> <>
<ScreenTitle title={title} scrollY={scrollY} /> {!hasResults ? (
{hasQuery && !hasResults ? (
<View style={styles.empty}> <View style={styles.empty}>
<Text <Text
style={[styles.emptyText, { color: colors.mutedForeground }]} style={[styles.emptyText, { color: colors.mutedForeground }]}
@@ -112,13 +103,13 @@ function SearchResultsBody({
</View> </View>
) : null} ) : null}
{hasQuery && results?.artists.length ? ( {results?.artists.length ? (
<View style={styles.section}> <View style={styles.section}>
<ContentCarousel title="Artists" content={results.artists} /> <ContentCarousel title="Artists" content={results.artists} />
</View> </View>
) : null} ) : null}
{hasQuery && results?.albums.length ? ( {results?.albums.length ? (
<View style={styles.section}> <View style={styles.section}>
<ContentCarousel title="Albums" content={results.albums} /> <ContentCarousel title="Albums" content={results.albums} />
</View> </View>
@@ -127,7 +118,7 @@ function SearchResultsBody({
} }
renderItem={renderItem} renderItem={renderItem}
ListFooterComponent={ ListFooterComponent={
hasQuery && playlistResults && playlistResults.length > 0 ? ( playlistResults && playlistResults.length > 0 ? (
<View style={styles.section}> <View style={styles.section}>
<ContentCarousel title="Playlists" content={playlistResults} /> <ContentCarousel title="Playlists" content={playlistResults} />
</View> </View>
+5 -49
View File
@@ -9,7 +9,6 @@ import {
collectionInset, collectionInset,
} from "@/components/collection-list" } from "@/components/collection-list"
import { tabletCardTextHeight } from "@/components/tablet-media-grid" import { tabletCardTextHeight } from "@/components/tablet-media-grid"
import { ScreenTitle } from "@/components/screen-title"
import { Link } from "expo-router" import { Link } from "expo-router"
import { useHeaderHeight } from "expo-router/react-navigation" import { useHeaderHeight } from "expo-router/react-navigation"
import Reanimated from "react-native-reanimated" import Reanimated from "react-native-reanimated"
@@ -152,16 +151,9 @@ function SongRows({ rows, inset }: { rows: number; inset?: boolean }) {
)) ))
} }
export function SongListSkeleton({ export function SongListSkeleton({ rows = 10 }: { rows?: number }) {
rows = 10,
title,
}: {
rows?: number
title?: string
}) {
return ( return (
<SkeletonScreen> <SkeletonScreen>
{title ? <ScreenTitle title={title} /> : null}
<SongRows rows={rows} /> <SongRows rows={rows} />
</SkeletonScreen> </SkeletonScreen>
) )
@@ -242,45 +234,23 @@ export function MediaGridSkeleton({
items = 6, items = 6,
contentInset = true, contentInset = true,
header, header,
title,
}: { }: {
items?: number items?: number
contentInset?: boolean contentInset?: boolean
/** The loaded list's `ListHeaderComponent`, so it keeps its position. */ /** The loaded list's `ListHeaderComponent`, so it keeps its position. */
header?: ReactNode header?: ReactNode
/** The loaded list's `ScreenTitle`, which replaces its top inset. */
title?: string
}) { }) {
return ( return (
<SkeletonScreen> <SkeletonScreen>
<MediaGridContent <MediaGridContent
items={items} items={items}
contentInset={contentInset && !title} contentInset={contentInset}
header={ header={header}
title ? (
<>
<MediaGridTitle title={title} />
{header}
</>
) : (
header
)
}
/> />
</SkeletonScreen> </SkeletonScreen>
) )
} }
function MediaGridTitle({ title }: { title: string }) {
const { horizontalPadding } = useMediaGridLayout()
return (
<ScreenTitle
title={title}
style={{ paddingHorizontal: horizontalPadding }}
/>
)
}
export function CarouselSkeleton() { export function CarouselSkeleton() {
return ( return (
<View style={styles.carousel}> <View style={styles.carousel}>
@@ -294,11 +264,10 @@ export function CarouselSkeleton() {
) )
} }
export function HomeSkeleton({ title }: { title: string }) { export function HomeSkeleton() {
return ( return (
<SkeletonScreen> <SkeletonScreen>
<View style={styles.home}> <View style={styles.home}>
<ScreenTitle title={title} style={styles.homeTitle} />
<CarouselSkeleton /> <CarouselSkeleton />
<CarouselSkeleton /> <CarouselSkeleton />
</View> </View>
@@ -419,17 +388,10 @@ export function CollectionDetailSkeleton({
) )
} }
export function ArtistListSkeleton({ export function ArtistListSkeleton({ rows = 12 }: { rows?: number }) {
rows = 12,
title,
}: {
rows?: number
title?: string
}) {
const colors = useThemeColors() const colors = useThemeColors()
return ( return (
<SkeletonScreen> <SkeletonScreen>
{title ? <ScreenTitle title={title} /> : null}
{Array.from({ length: rows }, (_, index) => ( {Array.from({ length: rows }, (_, index) => (
<View <View
key={index} key={index}
@@ -494,12 +456,6 @@ const styles = StyleSheet.create({
carousel: { gap: spacing.md, overflow: "hidden" }, carousel: { gap: spacing.md, overflow: "hidden" },
carouselRow: { flexDirection: "row", gap: spacing.md }, carouselRow: { flexDirection: "row", gap: spacing.md },
home: { padding: spacing.lg, gap: spacing.xl }, home: { padding: spacing.lg, gap: spacing.xl },
// Mirrors the home screen's title spacing.
homeTitle: {
paddingHorizontal: 0,
marginTop: -spacing.lg,
marginBottom: -spacing.md,
},
centeredHero: { alignItems: "center", padding: spacing.lg, gap: spacing.sm }, centeredHero: { alignItems: "center", padding: spacing.lg, gap: spacing.sm },
actions: { actions: {
flexDirection: "row", flexDirection: "row",
+5 -20
View File
@@ -6,7 +6,7 @@ import {
type ReactElement, type ReactElement,
} from "react" } from "react"
import { import {
type ScrollViewInstance, ScrollView,
View, View,
type NativeSyntheticEvent, type NativeSyntheticEvent,
type NativeScrollEvent, type NativeScrollEvent,
@@ -15,7 +15,6 @@ import Animated from "react-native-reanimated"
import { useSafeAreaInsets } from "react-native-safe-area-context" import { useSafeAreaInsets } from "react-native-safe-area-context"
import type { MediaItem } from "@/components/media-cards" import type { MediaItem } from "@/components/media-cards"
import { ScreenTitle, useScreenTitleScroll } from "@/components/screen-title"
import { useMediaGridLayout } from "@/hooks/use-media-grid-layout" import { useMediaGridLayout } from "@/hooks/use-media-grid-layout"
import { tabletLayoutTransition } from "@/lib/tablet-motion" import { tabletLayoutTransition } from "@/lib/tablet-motion"
import { useThemeColors } from "@/lib/theme" import { useThemeColors } from "@/lib/theme"
@@ -29,8 +28,6 @@ type GridProps = {
onEndReached?: () => void onEndReached?: () => void
ListHeaderComponent?: ReactElement ListHeaderComponent?: ReactElement
contentInset?: boolean contentInset?: boolean
/** iOS `ScreenTitle` shown above the grid; it replaces the top inset. */
title?: string
renderCard: (item: MediaItem, width: number) => ReactElement renderCard: (item: MediaItem, width: number) => ReactElement
} }
@@ -44,12 +41,9 @@ export function TabletMediaGrid({
onEndReached, onEndReached,
ListHeaderComponent, ListHeaderComponent,
contentInset = true, contentInset = true,
title,
renderCard, renderCard,
}: GridProps) { }: GridProps) {
const colors = useThemeColors() const colors = useThemeColors()
const { ref, scrollY: titleScrollY } =
useScreenTitleScroll<ScrollViewInstance>()
const insets = useSafeAreaInsets() const insets = useSafeAreaInsets()
const { columns, cardWidth, onLayout, horizontalPadding, gap, ready } = const { columns, cardWidth, onLayout, horizontalPadding, gap, ready } =
useMediaGridLayout() useMediaGridLayout()
@@ -108,27 +102,18 @@ export function TabletMediaGrid({
setViewportHeight(event.nativeEvent.layout.height) setViewportHeight(event.nativeEvent.layout.height)
}} }}
> >
<Animated.ScrollView <ScrollView
ref={ref}
onScroll={onScroll} onScroll={onScroll}
// Every frame, so the title pins smoothly on pull-down. scrollEventThrottle={32}
scrollEventThrottle={16}
contentInsetAdjustmentBehavior="automatic" contentInsetAdjustmentBehavior="automatic"
contentContainerStyle={{ contentContainerStyle={{
paddingTop: contentInset && !title ? horizontalPadding : 0, paddingTop: contentInset ? horizontalPadding : 0,
paddingBottom: paddingBottom + insets.bottom, paddingBottom: paddingBottom + insets.bottom,
}} }}
> >
<View <View
onLayout={(event) => setHeaderHeight(event.nativeEvent.layout.height)} onLayout={(event) => setHeaderHeight(event.nativeEvent.layout.height)}
> >
{title ? (
<ScreenTitle
title={title}
scrollY={titleScrollY}
style={{ paddingHorizontal: horizontalPadding }}
/>
) : null}
{ListHeaderComponent} {ListHeaderComponent}
</View> </View>
<View style={{ height: gridHeight }}> <View style={{ height: gridHeight }}>
@@ -151,7 +136,7 @@ export function TabletMediaGrid({
) )
})} })}
</View> </View>
</Animated.ScrollView> </ScrollView>
</Animated.View> </Animated.View>
) )
} }
+1 -8
View File
@@ -17,20 +17,13 @@ export const tabStackScreenTitles: Record<string, string> = {
"downloads/other": "Other Downloaded Songs", "downloads/other": "Other Downloaded Songs",
} }
/**
* iOS tab stacks render their titles in the scroll content with
* `ScreenTitle`, so the bar keeps the title (for back menus) but hides it.
*/
export const inlineTitleOptions: StackScreenOptions =
Platform.OS === "ios" ? { headerTitleStyle: { color: "transparent" } } : {}
export function useStackScreenOptions( export function useStackScreenOptions(
overrides?: StackScreenOptions overrides?: StackScreenOptions
): StackScreenOptions { ): StackScreenOptions {
const theme = useThemeColors() const theme = useThemeColors()
return { return {
headerLargeTitle: false, headerLargeTitle: true,
headerTransparent: true, headerTransparent: true,
headerTintColor: theme.foreground, headerTintColor: theme.foreground,
headerLargeTitleStyle: { color: theme.foreground }, headerLargeTitleStyle: { color: theme.foreground },