fix(mobile): use system colors for album and playlist menu button #111

Merged
joshuafhiggins merged 1 commits from t3/system-color-menu-button into main 2026-11-16 22:08:05 -05:00
Owner

The ... menu button on album and playlist screens was meant to use system light/dark colors (#59), but #75 wrapped it in PaletteIcon tone="foreground", which animates color to the artwork palette on Android. On iOS the hard-coded palette.isDark ? "#fff" : "#000" also tied it to the artwork rather than the system appearance, so a dark cover in light mode got a white icon.

Swapped the PaletteIcon for a plain Ionicons colored with useThemeColors().foreground, so it follows the system theme on both platforms.

Verified on the iPhone Duo simulator (light and dark, dark and light artwork, album and playlist) and the Pixel 10 emulator. Android is dark-only in this app (useIsDark returns true), so the button is always white there. Typecheck passes.

Back button: no change. On iOS it is the native glass back button and already uses the system tint (black in light, white in dark), matching the menu button. On Android it is renderArtworkBackButton, which is white on the always-dark artwork header, so it also matches.

Made with Claude Opus 5.5 in Claude Code (T3 Code).

🤖 Generated with Claude Code

The `...` menu button on album and playlist screens was meant to use system light/dark colors (#59), but #75 wrapped it in `PaletteIcon tone="foreground"`, which animates `color` to the artwork palette on Android. On iOS the hard-coded `palette.isDark ? "#fff" : "#000"` also tied it to the artwork rather than the system appearance, so a dark cover in light mode got a white icon. Swapped the `PaletteIcon` for a plain `Ionicons` colored with `useThemeColors().foreground`, so it follows the system theme on both platforms. Verified on the iPhone Duo simulator (light and dark, dark and light artwork, album and playlist) and the Pixel 10 emulator. Android is dark-only in this app (`useIsDark` returns true), so the button is always white there. Typecheck passes. Back button: no change. On iOS it is the native glass back button and already uses the system tint (black in light, white in dark), matching the menu button. On Android it is `renderArtworkBackButton`, which is white on the always-dark artwork header, so it also matches. Made with Claude Opus 5.5 in Claude Code (T3 Code). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
joshuafhiggins added 1 commit 2026-11-16 21:38:43 -05:00
joshuafhiggins merged commit be6caaaedb into main 2026-11-16 22:08:05 -05:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: joshuafhiggins/otunes#111