fix(mobile): keep the Android tab ripple static #114

Merged
joshuafhiggins merged 1 commits from t3/static-android-tab-ripple into main 2026-11-18 10:25:32 -05:00
Owner

On Android, tapping a tab while the artwork palette changes cut the ripple off or replayed it. The ripple color followed the artwork tint, so every palette swap sent a new color. react-native-screens then rebuilt Material's item backgrounds and killed the ripple from the tap that caused the swap. The ripple guard in our react-native-screens patch only skips unchanged values, so it couldn't help.

This uses a fixed ripple color (appleMusic.tabInactive), so the existing guard skips the reset. Title and icon colors already only change with the palette since #108.

Verified on a Pixel 10 emulator (release build) by tapping Home/Library from an album page, which swaps the palette on every tap:

  • Static color + guard (this PR): one full ripple per tap, fading smoothly through the palette swap.
  • Static color without the guard: the ripple was cut off or barely visible, so the patch hunk stays.

Not verified: a physical device. The test server's Convex deploy is missing intentCatalog:head, so the test builds skipped the Siri catalog sync locally (not part of this PR).

Changes made by Claude Opus 5.5 in Claude Code (T3 Code).

🤖 Generated with Claude Code

On Android, tapping a tab while the artwork palette changes cut the ripple off or replayed it. The ripple color followed the artwork tint, so every palette swap sent a new color. react-native-screens then rebuilt Material's item backgrounds and killed the ripple from the tap that caused the swap. The ripple guard in our react-native-screens patch only skips unchanged values, so it couldn't help. This uses a fixed ripple color (`appleMusic.tabInactive`), so the existing guard skips the reset. Title and icon colors already only change with the palette since #108. Verified on a Pixel 10 emulator (release build) by tapping Home/Library from an album page, which swaps the palette on every tap: - Static color + guard (this PR): one full ripple per tap, fading smoothly through the palette swap. - Static color without the guard: the ripple was cut off or barely visible, so the patch hunk stays. Not verified: a physical device. The test server's Convex deploy is missing `intentCatalog:head`, so the test builds skipped the Siri catalog sync locally (not part of this PR). Changes made by Claude Opus 5.5 in Claude Code (T3 Code). 🤖 Generated with [Claude Code](https://claude.com/claude-code)
joshuafhiggins added 1 commit 2026-11-17 12:17:57 -05:00
The Android tab ripple followed the artwork tint, so every palette swap
sent a new ripple color. react-native-screens then rebuilt Material's item
backgrounds and cut off the ripple from the tap that triggered the swap.
Use a fixed ripple color so the existing ripple guard skips the reset.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
joshuafhiggins merged commit b86ca9cd1f into main 2026-11-18 10:25:32 -05:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: joshuafhiggins/otunes#114