diff --git a/apps/mobile/components/media-context-menu.test.cjs b/apps/mobile/components/media-context-menu.test.cjs new file mode 100644 index 0000000..d8ab47a --- /dev/null +++ b/apps/mobile/components/media-context-menu.test.cjs @@ -0,0 +1,65 @@ +const { test } = require("node:test") +const assert = require("node:assert/strict") +const fs = require("node:fs") +const vm = require("node:vm") +const ts = require("typescript") + +test("the native menu keeps its trigger type when screen focus replaces the Siri wrapper", () => { + let focused = true + const imports = { + "react/jsx-runtime": { + jsx: (type, props) => ({ type, props }), + jsxs: (type, props) => ({ type, props }), + }, + "react-native": { Platform: { OS: "ios" }, View: "View" }, + expo: { requireNativeView: (_module, view) => view }, + "expo-router": { useIsFocused: () => focused }, + "expo-app-intents": { AppEntityView: "AppEntityView" }, + "@expo/ui/community/menu": {}, + "@/contexts/server-config": { useServerConfig: () => ({ config: null }) }, + "@/lib/media-links": { shouldShowShare: () => false }, + "@/lib/share-media-link": {}, + } + + function load(file) { + const module = { exports: {} } + const source = ts.transpileModule( + fs.readFileSync(`${__dirname}/${file}.tsx`, "utf8"), + { + compilerOptions: { + module: ts.ModuleKind.CommonJS, + jsx: ts.JsxEmit.ReactJSX, + }, + } + ).outputText + vm.runInNewContext(source, { + module, + exports: module.exports, + require: (name) => { + assert.ok(name in imports, `Unexpected import ${name}`) + return imports[name] + }, + }) + return module.exports + } + + const { MusicEntityView } = load("music-entity-view") + const { MediaContextMenu } = load("media-context-menu") + const card = { type: "Pressable", props: { children: "Album" } } + const triggers = [] + + for (const nextFocus of [true, false, true, false, true]) { + focused = nextFocus + const entity = MusicEntityView({ kind: "album", id: "1", children: card }) + const menu = MediaContextMenu({ children: entity, onAction() {} }) + const nativeMenu = menu.type(menu.props) + const trigger = nativeMenu.props.children[0] + triggers.push(trigger) + + // Fabric must retain this host even when its child changes native type. + assert.equal(trigger.props.collapsable, false) + assert.equal(trigger.type, triggers[0].type) + assert.equal(trigger.props.children.type, focused ? "AppEntityView" : "View") + assert.equal(trigger.props.children.props.children, card) + } +}) diff --git a/apps/mobile/components/media-context-menu.tsx b/apps/mobile/components/media-context-menu.tsx index c31bc2e..7b800de 100644 --- a/apps/mobile/components/media-context-menu.tsx +++ b/apps/mobile/components/media-context-menu.tsx @@ -3,6 +3,7 @@ import { requireNativeView } from "expo" import type { ComponentType, ReactNode } from "react" import { Platform, + View, type StyleProp, type ViewProps, type ViewStyle, @@ -241,7 +242,9 @@ function NativeMediaContextMenu({ return ( - {children} + {/* The native menu retains its first trigger. Keep that view mounted when + focus changes replace the Siri entity wrapper inside it. */} + {children} {buildMediaMenuActions({ ...actionConfig, share }).map((action) => (