fix(web): unfavorite from track list menus #133

Merged
joshuafhiggins merged 1 commits from t3/fix-unfavorite-menu into main 2026-11-20 00:26:20 -05:00
Owner

In album, playlist, library song and queue sidebar lists, the song menu showed Unfavorite for favorited songs, but choosing it favorited them again. `runSongsAction` always called `favoriteSongs`.

Fix

  • `runSongsAction` `favorite` now unfavorites when every target song is already favorited, and favorites them otherwise (`toggleSongsFavorite`).
  • New `areSongsFavorite(ids)` in the favorites provider replaces the now-unused `favoriteSongs`.
  • `TrackRow` takes `selectionFavorited`, so a multi-song selection shows the label that matches what the action will do. All five list views pass it.
  • The playlist header menu gets the same `favorited` state, so its label also matches.

The Favorites playlist still hides Favorite and removes songs through its own "Unfavorite" item.


Changes made by Claude Opus 5.5 (claude-opus-5-5) running in Claude Code via T3 Code.

🤖 Generated with Claude Code

In album, playlist, library song and queue sidebar lists, the song menu showed **Unfavorite** for favorited songs, but choosing it favorited them again. \`runSongsAction\` always called \`favoriteSongs\`. **Fix** - \`runSongsAction\` \`favorite\` now unfavorites when every target song is already favorited, and favorites them otherwise (\`toggleSongsFavorite\`). - New \`areSongsFavorite(ids)\` in the favorites provider replaces the now-unused \`favoriteSongs\`. - \`TrackRow\` takes \`selectionFavorited\`, so a multi-song selection shows the label that matches what the action will do. All five list views pass it. - The playlist header menu gets the same \`favorited\` state, so its label also matches. The Favorites playlist still hides Favorite and removes songs through its own "Unfavorite" item. --- Changes made by Claude Opus 5.5 (claude-opus-5-5) running in Claude Code via T3 Code. 🤖 Generated with [Claude Code](https://claude.com/claude-code)
joshuafhiggins added 1 commit 2026-11-20 00:25:22 -05:00
The track list menu showed "Unfavorite" for favorited songs but always
favorited. runSongsAction now unfavorites when every target song is
already favorited, and rows in a selection label the item by that same
rule.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
joshuafhiggins force-pushed t3/fix-unfavorite-menu from 0b5e1b6731 to f867a4f251 2026-11-20 00:25:22 -05:00 Compare
joshuafhiggins merged commit 48aef3df62 into main 2026-11-20 00:26:20 -05:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: joshuafhiggins/otunes#133