fix(web): keep player colors and dimensions consistent #65

Merged
joshuafhiggins merged 2 commits from t3/web-player-light-mode into main 2026-11-03 15:36:11 -05:00
Owner

The web player forced dark colors in light mode and shrank while track metadata was loading.

Use the light theme's card surface and foreground for the player, inactive controls, and seek track. Keep the existing charcoal surface and white controls in dark mode. The Lossless mark uses the same surface color as the player in either theme. Also replace the empty player's missing logo reference with the existing logo asset. Reserve the loaded content height in empty and loading states so the bar keeps its shape; the queue sidebar can still narrow it.

Validation: web typecheck and targeted ESLint pass. Tested the running app against the live library in light and dark modes, including hover states, keyboard seek focus, volume popup, and the 390px layout. Confirmed the Lossless mark's background matches the player in both themes. Test account playback was left paused.

Light mode:
Light player

Light mode volume control:
Light volume popup

Dark mode:
Dark player

Loading-state validation used the running app with real live-library WebSocket responses held and then released, without replacing their data. Loading and loaded player bounds were identical: 1152×90 on desktop, 358×62 on mobile, and 864×90 with the desktop queue sidebar open. Web typecheck and targeted ESLint pass.

While library data is loading:
Stable loading player

After the same live responses arrive:
Loaded player with identical bounds

Changes made by GPT-6.1 Sol through the Codex harness in T3 Code.

The web player forced dark colors in light mode and shrank while track metadata was loading. Use the light theme's card surface and foreground for the player, inactive controls, and seek track. Keep the existing charcoal surface and white controls in dark mode. The Lossless mark uses the same surface color as the player in either theme. Also replace the empty player's missing logo reference with the existing logo asset. Reserve the loaded content height in empty and loading states so the bar keeps its shape; the queue sidebar can still narrow it. Validation: web typecheck and targeted ESLint pass. Tested the running app against the live library in light and dark modes, including hover states, keyboard seek focus, volume popup, and the 390px layout. Confirmed the Lossless mark's background matches the player in both themes. Test account playback was left paused. Light mode: ![Light player](https://files.gitcoffee.dev/files/light-player-vibap5qo7ovrjmye.png) Light mode volume control: ![Light volume popup](https://files.gitcoffee.dev/files/light-volume-ezvirc2ua5xndeka.png) Dark mode: ![Dark player](https://files.gitcoffee.dev/files/dark-player-xzc6jnichkcyoiwr.png) Loading-state validation used the running app with real live-library WebSocket responses held and then released, without replacing their data. Loading and loaded player bounds were identical: 1152×90 on desktop, 358×62 on mobile, and 864×90 with the desktop queue sidebar open. Web typecheck and targeted ESLint pass. While library data is loading: ![Stable loading player](https://files.gitcoffee.dev/files/desktop-loading-y07voit6lkts6gkc.png) After the same live responses arrive: ![Loaded player with identical bounds](https://files.gitcoffee.dev/files/desktop-loaded-ubkfk4aszkltlrsz.png) Changes made by GPT-6.1 Sol through the Codex harness in T3 Code.
joshuafhiggins added 1 commit 2026-11-03 15:30:35 -05:00
joshuafhiggins added 1 commit 2026-11-03 15:34:14 -05:00
joshuafhiggins changed title from fix(web): match player colors to the app theme to fix(web): keep player colors and dimensions consistent 2026-11-03 15:34:38 -05:00
joshuafhiggins merged commit 54c7dda06f into main 2026-11-03 15:36:11 -05:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: joshuafhiggins/otunes#65